Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace networkConfig #540

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Replace networkConfig #540

wants to merge 1 commit into from

Conversation

bshephar
Copy link
Contributor

As part of a wider effort to consolidate configuration around ansibleVars without unnecessary abstractions, this change moves the networkConfig template from a bespoke API abstraction via spec.nodeTemplate.networkConfig.template to the relevant Ansible variable: edpm_network_config_template.

@bshephar
Replace networkConfig
9dcfcca 
Signed-off-by: Brendan Shephard <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bshephar
Once this PR has been reviewed and has the lgtm label, please assign olliewalsh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bshephar bshephar mentioned this pull request Sep 15, 2023
Merged
@bshephar bshephar marked this pull request as draft September 15, 2023 03:38
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5ec9d74ae0b349219113fa7ea414b2d8

✔️ openstack-k8s-operators-content-provider SUCCESS in 58m 27s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 41m 33s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 45m 39s

@fao89
Copy link
Contributor

fao89 commented Sep 21, 2023

recheck

@fao89
Copy link
Contributor

fao89 commented Sep 21, 2023

/retest-required

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/cd5ef7ebe8f44bc7a672d0f08c3cedd5

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 15m 28s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 1h 02m 22s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 01m 53s

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

slagle
slagle reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@slagle slagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bshephar Can we close this PR? I don't think it's needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slagle slagle slagle left review comments

@cjeanner cjeanner Awaiting requested review from cjeanner

@raukadah raukadah Awaiting requested review from raukadah

Assignees
No one assigned
Labels
do-not-merge/work-in-progress needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bshephar @fao89 @openshift-merge-robot @slagle